change the default versions to be clearly placeholders #132
Conversation
Signed-off-by: Kevin <[email protected]>
|
Skipping CI for Draft Pull Request. |
Signed-off-by: Kevin <[email protected]>
Signed-off-by: Kevin <[email protected]>
CONTRIBUTING.md
Outdated
| @@ -31,14 +31,21 @@ If changes are made to any Go code (like in the `controllers` dir for example), | |||
| - This will check and build/compile the modified code | |||
|
|
|||
| For building and pushing a new version of the operator image: | |||
| - `make image-build -e IMG=<image-repo/image-name>` | |||
| - `make image-push -e IMG<image-repo/image-name>` | |||
| - `make image-build -e IMG_TAG_BASE=<image-repo/image-name> VERSION=<semver>` | |||
There was a problem hiding this comment.
I think that should be IMAGE_TAG_BASE instead of IMG_TAG_BASE.
CONTRIBUTING.md
Outdated
|
|
||
| For deploying onto a cluster: | ||
| - First, either set `KUBECONFIG` or ensure you are logged into a cluster in your environment | ||
| - `make install` | ||
| - `make deploy -e IMG=<image-repo/image-name>` | ||
|
|
||
| For building and pushing a new version of the bundled operator image: | ||
| - `make bundle-build -e IMG_TAG_BASE=<image-repo/image-name> VERSION=<new semver> PREVIOUS_VERSION=<semver to replace>` |
There was a problem hiding this comment.
IMG_TAG_BASE -> IMAGE_TAG_BASE
| @@ -241,6 +241,7 @@ bundle: defaults manifests kustomize install-operator-sdk ## Generate bundle man | |||
| cd config/manifests && $(KUSTOMIZE) edit add patch --patch '[{"op":"add", "path":"/spec/replaces", "value": "codeflare-operator.v$(PREVIOUS_VERSION)" }]' --kind ClusterServiceVersion | |||
| $(KUSTOMIZE) build config/manifests | $(OPERATOR_SDK) generate bundle $(BUNDLE_GEN_FLAGS) | |||
| $(MAKE) validate-bundle | |||
| git restore config/* | |||
There was a problem hiding this comment.
nit: we may want to git restore also in the deploy target, for consistency.
Signed-off-by: Kevin <[email protected]>
KPostOffice
force-pushed
the
make-versions-useless
branch
from
334f16e to
44a4696
Compare
|
/lgtm |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.